Gamemode 4 Labs - scuba-gear

Giovata 23-Nov-18 11:26 PM

hi

kyrkis 23-Nov-18 11:26 PM

I'd like to thank you for all your support

xD

Diamondback88 23-Nov-18 11:27 PM

First order is business is getting someone to assume control of making the datapack

Giovata 23-Nov-18 11:27 PM

copy the description here and pin it

also, change the organisation to have a "development" category and one text channel per datapack and only one voice channel for the full category

Diamondback88 23-Nov-18 11:28 PM

Kyrkis: Module: Scuba Gear Main feature: dyed leather armor crafted in custom crafter that has special abilities like ostara boots. Scuba helmet and chestplate: chestplate crafted with two bottles and selected material as air tanks, combined with the scuba helmet you get water breathing for about 3 minutes after entering the water. Flippers: Gives dolphins grace when in swimming animation, no effect while just in idle animation underwater and slowness 2 when on land. These items would be crafted using: slime, dried kelp or leather, possibly nautilus shells too. Use of scutes or turtle helmets would be nice too as they do not have much use yet. (edited)

Pinned a message.

BluePsychoRanger 23-Nov-18 11:29 PM

I could make the datapack

Diamondback88 23-Nov-18 11:29 PM

Ok

kyrkis 23-Nov-18 11:30 PM

what material will we use for the scuba gear, we can't only use scutes

BluePsychoRanger 23-Nov-18 11:31 PM

Iron or gold

Scuba gear could be golden armor

kyrkis 23-Nov-18 11:32 PM

well

we dont want it to give much defence at all

only swimming abilities

BluePsychoRanger 23-Nov-18 11:33 PM

Well I'd say that scuba gear is a lot more protective than normal skin...

kyrkis 23-Nov-18 11:34 PM

Here are some recipie ideas, the magenta concrete is just any material we want to use:

this is not official, just ideas

ok?

Just some ideas on how it could look (the steve head would be another player head)

krikestof 23-Nov-18 11:39 PM

can i ask what the goal is of scuba gear? is it meant as help for early or for mid/late game?

kyrkis 23-Nov-18 11:39 PM

well, the flippers are for much faster swimming, so thats useful through it all

but the breathing is basically just an improved turtle helm

Dennis 23-Nov-18 11:42 PM

If it's an improved turtle shell, shouldn't it use one in its recipe?

BluePsychoRanger 23-Nov-18 11:52 PM

I believe the goal is to make underwater adventure easier overall, but not too overpowered/super easy to obtain @krikestof

krikestof 23-Nov-18 11:55 PM

i think that 3 minutes of underwater breathing is too much i suggest 1 minute or 1 minute 30 seconds of water breathing

Diamondback88 24-Nov-18 12:12 AM

I say 2 minutes

But I'm not completely opposed to 3 mins

BluePsychoRanger 24-Nov-18 12:13 AM

I agree with 1:30

Diamondback88 24-Nov-18 12:14 AM

I'm also not opposed to 1:30 either

Dennis 24-Nov-18 11:59 AM

Does speed effect work while swimming?

federick 24-Nov-18 12:01 PM

I think so

krikestof 24-Nov-18 04:13 PM

speed only worked for swimming if someone had depth strider 3 on their boots in 1.12 but i haven't tested it yet in 1.13

Lue 24-Nov-18 04:28 PM

idk about without depth strider (edited)

but it definitely works with depth strider in 1.13

BluePsychoRanger 25-Nov-18 08:07 PM

https://docs.google.com/document/d/1-MeYGJjJYmge563-RwL7wnemZ4j2IqA3RUaoSNwY0hw/edit?usp=sharing

SCUBA Gear

Crafting In a custom crafter G T G - - - G P G -> - - - - - - - - H G - Gold Ingot T - Turtle Shell P - Glass Pane H - SCUBA Helmet (Custom Player Skull, Aqua Affinity I) G W G - - - S G S -> - - - G G G - - C G - Gold Ingot S - Scute W ...

BluePsychoRanger 25-Nov-18 08:17 PM

^Please check out and review this module documentation before I submit it to the GM4 GitHub (edited)

ToffeeMax 25-Nov-18 08:28 PM

Feedback given @BluePsychoRanger : ) (edited)

BluePsychoRanger 25-Nov-18 08:28 PM

Thanks

BluePsychoRanger 25-Nov-18 08:40 PM

@ToffeeMax I don't wanna make the SCUBA helmet use 7 gold ingots instead of 4 because, reasonably, I'd have to buff the armor points it gives (right now it's at 2, as the Turtle Helmet gives 2 amor points). I don't want the helmet to be too overpowered, as it cannot break. Also increasing the armor points by 1 would mean a full set of SCUBA gear (without any leggings) would also give Slowness I with Weighted Armour installed, and the gear already slows down the player significantly. I do, however, like the idea of dolphin relationships; let's hear from the rest of these people though, and see if they agree.

ToffeeMax 25-Nov-18 08:45 PM

Oke Doke

: )

BluePsychoRanger 25-Nov-18 09:23 PM

@kyrkis Check out the documentation above, and make any suggestions, it's your idea, so I wanna know your opinion. Also check out Toffee's ideas and agree/disagree with them.

kyrkis 25-Nov-18 09:49 PM

looking good

ToffeeMax 25-Nov-18 10:50 PM

Very useful feedback @kyrkis cry

BluePsychoRanger 26-Nov-18 12:07 AM

Toffee, I tried adding the dolphin relationship status buff, but it appears that the GotFish tag is somewhat broken, and whenever I got the data from the dolphin, it always returned it as 0, even when I physically gave it a fish.

BluePsychoRanger 26-Nov-18 01:03 AM

I've changed the water breathing effect to conduit power, as removing water breathing would cause problems with the water breathing potion.

Also removed Aqua Affinity from the SCUBA Helmet, as conduit power speeds up underwater mining

BluePsychoRanger 26-Nov-18 01:32 AM

@Diamondback88 This module has been submitted to the GM4 GitHub

Diamondback88 26-Nov-18 01:36 AM

Pinned a message.

BluePsychoRanger 26-Nov-18 11:43 PM

https://github.com/Gamemode4Dev/GM4_Datapacks/pull/117

New module: SCUBA Gear by BluePsychoRanger · Pull Request #117 ·...

Adds craftable scuba gear to aid in ocean travel, but slows down ground travel. Original Idea by Kyrkis. Documentation: https://docs.google.com/document/d/1-MeYGJjJYmge563-RwL7wnemZ4j2IqA3RUaoSNwY0...

Sparks left a review, to possibly buff the under water effects, or not give such high land debuffs. What do you guys think? Namely, should we increase the time of Conduit Power (Toffee suggested this as well). But note that it's really easy to refresh the conduit power by moving your head into a non-water block (even a water-logged one) and going back into water.

tomh 26-Nov-18 11:57 PM

Are you using the waterlogged block tag for the testing?

BluePsychoRanger 27-Nov-18 12:01 AM

It checks for water. Is there a waterlogged block tag? Or should I add one and also check water-logged blocks to not remove the conduit power?

tomh 27-Nov-18 12:04 AM

I believe there is one as default...

But it certainly should recognise waterlogged kelp and stuff as water

BluePsychoRanger 27-Nov-18 12:04 AM

Yeah, I forgot about that until after I submitted it; I'll make that change soon

BluePsychoRanger 27-Nov-18 03:17 AM

The SCUBA gear now keeps the conduit effect in water logged blocks, and lasts for 4 minutes.

BluePsychoRanger 10-Dec-18 08:15 AM

Pinned a message.

Misode 31-Jan-19 11:25 AM

@BluePsychoRanger What I actually meant it having command to check if the player is wearing any scuba gear, because that's not going to happen a lot

Also a function with 1 command is less efficient than just putting that command after run

main

execute as @a[gamemode=!spectator,nbt={Inventory:[{tag:{gm4_scuba_gear:{}}}]}] run function scuba_gear:equipped

equipped

execute if block ~ ~1 ~ water if entity @s[nbt={Inventory:[{Slot:103b,tag:{gm4_scuba_gear:{item:"helmet"}}},{Slot:102b,tag:{gm4_scuba_gear:{item:"tank"}}}]}] run function scuba_gear:breath execute if block ~ ~1 ~ #scuba_gear:water_loggable[waterlogged=true] if entity @s[nbt={Inventory:[{Slot:103b,tag:{gm4_scuba_gear:{item:"helmet"}}},{Slot:102b,tag:{gm4_scuba_gear:{item:"tank"}}}]}] run function scuba_gear:breath effect give @s[scores={gm4_sg_swim=1..},nbt={Inventory:[{Slot:100b,tag:{gm4_scuba_gear:{item:"flippers"}}}]}] dolphins_grace 2 0 true

(edited)

Sparks 31-Jan-19 11:35 AM

Once Misode is happy with his requested changes I'll approve this module as Special and Blue are both very busy atm

BluePsychoRanger 31-Jan-19 03:33 PM

@Misode the scuba gear is not only equipped to the feet slot... the flippers and tank+helmet have separate effects independent of each other

Misode 31-Jan-19 03:45 PM

I know, but I'm saying it would be more efficient to first check if there is a player with a scuba gear item in their inventory, since I assume that's not going to happen often

But I'm happy with that current version if that seems like over complicating things

BluePsychoRanger 31-Jan-19 04:02 PM

In your suggestion, it says slot:100b. Did you mean to check if there’s scuba gear anywhere the inventory?